EuiErrorBoundary: converted to Typescript #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 18, 2019
|
One thing is, I couldn't convert the component to a Functional Component because React Hooks does not have a hook for |
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
chandlerprall
suggested changes
Dec 18, 2019
chandlerprall
suggested changes
Dec 19, 2019
|
@chandlerprall could you take a look if I got it all? |
chandlerprall
suggested changes
Dec 19, 2019
There was a problem hiding this comment.
Updates look good! Few last items from a final pass and this should be good to merge
- added a request around the
Errorinterface - changelog entry needs to be moved back to the top section, as we just had a release which moved things around
- delete src/components/error_boundary/index.d.ts
- reference to the index.d.ts needs to be removed from
Line 4 in 3bf9df5
|
Think I got it all |
|
jenkins test this |
chandlerprall
suggested changes
Dec 26, 2019
chandlerprall
approved these changes
Dec 26, 2019
|
Thank you once again, @ffknob ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2661
Converted
EuiErrorBoundaryto Typescript.Checklist